EQEmulator Forums - More issues with scribespells

EQEmulator Forums (https://www.eqemulator.org/forums/index.php)

- Development::Bug Reports (https://www.eqemulator.org/forums/forumdisplay.php?f=591)

- - More issues with scribespells (https://www.eqemulator.org/forums/showthread.php?t=28871)

More issues with scribespells

I have a quest turn in for lvl 66 spells, lvl 67 spells, etc.

Just those levels, here is the script.

Code:

sub EVENT_ITEM {



#level 66 spells - trakanon

if (plugin::check_handin(\%itemcount, 1267 => 1)) {

quest::scribespells(66,66);

$client->Message(7, "Zelus says, 'This is most interesting, and most ancient. Well I can show you how to read this and you will be on your way in no time!'");

}



#level 67 - gukb

if (plugin::check_handin(\%itemcount, 1270 => 1)) {

quest::scribespells(67,67);

$client->Message(7, "Zelus says, 'This is most interesting, and most ancient. Well I can show you how to read this and you will be on your way in no time!'");

}



#level 68 - mire

if (plugin::check_handin(\%itemcount, 1267 => 1)) {

quest::scribespells(68,68);

$client->Message(7, "Zelus says, 'This is most interesting, and most ancient. Well I can show you how to read this and you will be on your way in no time!'");

}



else {

             plugin::return_items(\%itemcount);

        }

}

Players are reporting that when they do the turn in for the lvl 66 spells, it's deleting many older spells. In the case of a cleric it's scribing their 66 spells but deleting Complete Healing..which is a big hurt lol. I don't have anything set up for traindiscs yet so I'm not sure if it's having the same issues still. Anyway would anybody be able to look into this please?

It appears that the scribespells command starts enscribing spells at slot 0 in the character's spellbook.

As a temporary workaround, you could instruct players to move their spells out of the first couple of pages of their spellbook before using the spell scribing NPC to keep from losing them.

Yeah spellscribe (even on Live during Beta) overwrites everything in the spellbook, starting at page 1.

is there anyway we can change it to instead just place it after the last spell in the spell book?

That would be the best way to do it, but that would require a change to the source code. What we would need it to do is:

1. Check each spell being scribed to see if it is already in the player's spell book before doing anything. If it is already in the spell book, it does not rescribe it. This would stop it from repositioning spells if people have re-organized their spell book.

2. For each spell that gets scribed, it would search the Player Profile for any free slots and scribe each spell in the first available slot.

If we could get it to work like that, it should be perfect. Though, I think it might be tricky to have it look through the Player Profile like that. I really don't know how to make it do that correctly, or I would attempt to fix this issue myself.

anyone looking into this yet?

I think I may be able to work on & implement a fix today, along with some other commits I've been working on.

I just added the fix in Rev 830.

I finally got around to testing it out and I have to say you did a great job fixing it. I couldn't find any problems.